all 26 comments

[–]magnora7 3 insightful - 2 fun3 insightful - 1 fun4 insightful - 2 fun -  (24 children)

We have it, but it only blocks private messages and not posts and comments. It has to be expanded to have more functionality. This is currently priority #19 on our to-do list out of the 61 total open feature requests. We'll get there eventually

[–]wizzwizz4 1 insightful - 2 fun1 insightful - 1 fun2 insightful - 2 fun -  (22 children)

psst. post these on GitHub Issues.

[–]magnora7 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (21 children)

Well we're not going to share all 61 at once because it shows all our vulnerabilities from a security standpoint. I think we'll release them about 10-15 at a time like we have been lately. But yeah I guess /u/d3rr could you please convert the roadmap release points here in to github issues, if it's not too much trouble: https://saidit.net/s/SaidIt/comments/kbk/saiditnet_april_17_2019_html5_expandos_now/

[–]d3rr 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Sure man

[–]d3rr 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (19 children)

alright all of these roadmap items are posted on github aside from the iOS app. It doesn't feel right to file that as an issue against the saidit repo.

cc /u/wizzwizz4

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (18 children)

Cool, nice work. You can mark the github job about the image expansion as finished, too. If you didn't already :)

[–]d3rr 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (17 children)

Will do. I dislike some of your CSS changes but we'll see what happens. I think they regress mobile, I can fix them in the responsive styles.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (16 children)

If you want to walk some of my changes back that’s ok. The comment css does seem a little finicky. But the post expands code is good I think. We’re at least in the ballpark

[–]d3rr 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (7 children)

Well I made some adjustments to the CSS that had the expandos not resizing well all day, sorry about that. Anyway it's fixed now and all of the different use cases seem to be working well, like that image in the sidebar. If you could re-test and make sure it's acting the same as how you had it that'd be cool.

Also, an idea about #4 here, the default sub sort for the home page, should it maybe be site-wide instead of just for the home page? If you want to save a click to get away from hot on the home page, then maybe you want to do that elsewhere? It just seems weird to have a home-page only preference. Anyway it could just as easily be that or the original home page only idea, or two new preferences.

Furthermore, if you change the sort away from hot, does the tab order change? Should the default sort's tab always be positioned leftmost?

Just trying to get the github issue dialed in for takeoff https://github.com/libertysoft3/saidit/issues/30

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (6 children)

Cool, thanks for getting the bugs worked out of the image resizing.

Also, an idea about #4 here, the default sub sort for the home page, should it maybe be site-wide instead of just for the home page?

Can you elaborate? I don't follow what you mean. Can you give an example? I think a broader scope would be OK, but I'm just not sure what you mean exactly.

I would leave the tab order alone, that's fine imo.

[–]d3rr 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (5 children)

So the proposed new feature is "Everytime I go to my home page I am looking at tab 'new'". What about doing this sitewide, "Everytime I visit any sub I am looking at tab 'new'".

[–]wizzwizz4 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (7 children)

(cc /u/d3rr)

Documenting everything you touch is probably a good principle, if you plan for other people to help with the code long-term. I haven't been doing that because I don't have wiki access / wouldn't know where to document it, but if you want me to I can start.

[–]d3rr 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (5 children)

There's no way we can document all code changes. We have already made hundreds, it'd be like 4 pages of solid gibberish documentation by now. The code base can be diffed.

[–]wizzwizz4 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (4 children)

No, I mean document the parts of the code – as in, what the code does. So, you could have a section "media" which has a brief summary of the client-side and server-side media handling systems; given that finding the code is probably the hardest part of #23 and other similar things, this would make similar changes in future significantly easier if such a page is filled in when that issue is resolved.

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Well my changes should be in the github update d3rr has/will push, that will show the exact changes I made.

[–]sawboss 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (1 child)

Why do you want to hide from bad ideas instead of arguing against them?

[–]Flesh[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (0 children)

I would love to find interesting, well-articulated bad ideas and argue against them.

I'll have more time to do this if I block out the noise.